[action] [PR:27704] [docker-fpm-frr]: Fix tcmalloc package name for Trixie armhf#27758
Open
mssonicbld wants to merge 1 commit into
Open
[action] [PR:27704] [docker-fpm-frr]: Fix tcmalloc package name for Trixie armhf#27758mssonicbld wants to merge 1 commit into
mssonicbld wants to merge 1 commit into
Conversation
#### Why I did it PR sonic-net#27580 (FRR tcmalloc build) introduced `libgoogle-perftools4` as a runtime dependency in the docker-fpm-frr Dockerfile. This breaks the marvell-prestera-armhf build because on Debian Trixie armhf, the time64 transition renames this package to `libgoogle-perftools4t64` — the old name has no installation candidate. The CI did not catch this because docker-fpm-frr was cached for the armhf build during the original PR validation. #### How I did it Changed `libgoogle-perftools4` → `libgoogle-perftools4t64` in `dockers/docker-fpm-frr/Dockerfile.j2`. Since docker-fpm-frr is always Trixie-based (`DOCKER_SWSS_LAYER_TRIXIE`), `libgoogle-perftools4t64` is the correct package name for all architectures (amd64, arm64, armhf). This matches the pattern used by: - `sonic-slave-trixie/Dockerfile.j2` (line 227): `libgoogle-perftools4t64` - `dockers/docker-platform-monitor/Dockerfile.j2`: `librrd8t64` - `dockers/docker-sonic-mgmt-framework/Dockerfile.j2`: `libcurl4t64` #### How to verify it - Verified `libgoogle-perftools4t64` exists on Trixie for both [armhf](https://packages.debian.org/trixie/armhf/libgoogle-perftools4t64) and [amd64](https://packages.debian.org/trixie/amd64/libgoogle-perftools4t64) via Debian package tracker - CI pipeline should rebuild docker-fpm-frr for marvell-prestera-armhf (cache miss due to Dockerfile change) #### Which release branch to backport - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 #### Tested branch master #### Description for the changelog Fix docker-fpm-frr tcmalloc dependency package name for Trixie armhf (time64 transition) #### Link to config_db schema for YANG module changes N/A Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Collaborator
Author
|
Original PR: #27704 |
5 tasks
Collaborator
Author
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
PR #27580 (FRR tcmalloc build) introduced
libgoogle-perftools4as a runtime dependency in the docker-fpm-frr Dockerfile. This breaks the marvell-prestera-armhf build because on Debian Trixie armhf, the time64 transition renames this package tolibgoogle-perftools4t64— the old name has no installation candidate.The CI did not catch this because docker-fpm-frr was cached for the armhf build during the original PR validation.
How I did it
Changed
libgoogle-perftools4→libgoogle-perftools4t64indockers/docker-fpm-frr/Dockerfile.j2.Since docker-fpm-frr is always Trixie-based (
DOCKER_SWSS_LAYER_TRIXIE),libgoogle-perftools4t64is the correct package name for all architectures (amd64, arm64, armhf). This matches the pattern used by:sonic-slave-trixie/Dockerfile.j2(line 227):libgoogle-perftools4t64dockers/docker-platform-monitor/Dockerfile.j2:librrd8t64dockers/docker-sonic-mgmt-framework/Dockerfile.j2:libcurl4t64How to verify it
libgoogle-perftools4t64exists on Trixie for both armhf and amd64 via Debian package trackerWhich release branch to backport
Tested branch
master
Description for the changelog
Fix docker-fpm-frr tcmalloc dependency package name for Trixie armhf (time64 transition)
Link to config_db schema for YANG module changes
N/A
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com